at://nekomimi.pet/sh.tangled.repo.pull/3maddkhcucj22
Back to Collection
Record JSON
{
"$type": "sh.tangled.repo.pull",
"createdAt": "2025-12-19T09:05:26Z",
"patch": "From 8e89ab79c3ee157fbd34767f9d8d65bad9ff2608 Mon Sep 17 00:00:00 2001\nFrom: \"@nekomimi.pet\" \u003cmeowskulls@nekomimi.pet\u003e\nDate: Fri, 19 Dec 2025 02:51:47 -0500\nSubject: [PATCH] clean up debug logs\n\n---\n crates/jacquard-axum/src/service_auth.rs | 13 +++----------\n crates/jacquard-oauth/src/client.rs | 2 --\n crates/jacquard-oauth/src/request.rs | 5 -----\n crates/jacquard/src/client/bff_session.rs | 5 +----\n 4 files changed, 4 insertions(+), 21 deletions(-)\n\ndiff --git a/crates/jacquard-axum/src/service_auth.rs b/crates/jacquard-axum/src/service_auth.rs\nindex 57e7efe0..59d61a5f 100644\n--- a/crates/jacquard-axum/src/service_auth.rs\n+++ b/crates/jacquard-axum/src/service_auth.rs\n@@ -572,17 +572,10 @@ fn extract_signing_key(methods: \u0026[VerificationMethod]) -\u003e Option\u003cPublicKey\u003e {\n \n match codec {\n // p256-pub (0x1200)\n- [0x80, 0x24] =\u003e PublicKey::from_p256_bytes(key_material).inspect_err(|e| {\n- tracing::error!(\"Failed to parse p256 public key: {}\", e);\n- }).ok(),\n+ [0x80, 0x24] =\u003e PublicKey::from_p256_bytes(key_material).ok(),\n // secp256k1-pub (0xe7)\n- [0xe7, 0x01] =\u003e PublicKey::from_k256_bytes(key_material).inspect_err(|e| {\n- tracing::error!(\"Failed to parse secp256k1 public key: {}\", e);\n- }).ok(),\n- _ =\u003e {\n- tracing::error!(\"Unsupported public key multicodec: {:?}\", codec);\n- None\n- },\n+ [0xe7, 0x01] =\u003e PublicKey::from_k256_bytes(key_material).ok(),\n+ _ =\u003e None,\n }\n }\n \ndiff --git a/crates/jacquard-oauth/src/client.rs b/crates/jacquard-oauth/src/client.rs\nindex 0aeca2c5..325882ed 100644\n--- a/crates/jacquard-oauth/src/client.rs\n+++ b/crates/jacquard-oauth/src/client.rs\n@@ -280,8 +280,6 @@ where\n token_set,\n };\n \n- dbg!(\u0026client_data);\n-\n self.create_session(client_data).await\n }\n Err(e) =\u003e Err(e.into()),\ndiff --git a/crates/jacquard-oauth/src/request.rs b/crates/jacquard-oauth/src/request.rs\nindex 088793d7..fb0a5e5e 100644\n--- a/crates/jacquard-oauth/src/request.rs\n+++ b/crates/jacquard-oauth/src/request.rs\n@@ -517,11 +517,6 @@ pub async fn par\u003c'r, T: OAuthResolver + DpopExt + Send + Sync + 'static\u003e(\n prompt: prompt.map(CowStr::from),\n };\n \n- #[cfg(feature = \"tracing\")]\n- tracing::debug!(\n- parameters = ?parameters,\n- \"par:\"\n- );\n if metadata\n .server_metadata\n .pushed_authorization_request_endpoint\ndiff --git a/crates/jacquard/src/client/bff_session.rs b/crates/jacquard/src/client/bff_session.rs\nindex f655bd2b..98eaee4b 100644\n--- a/crates/jacquard/src/client/bff_session.rs\n+++ b/crates/jacquard/src/client/bff_session.rs\n@@ -107,10 +107,7 @@ impl ClientAuthStore for BrowserAuthStore {\n })?;\n Ok(Some(data))\n }\n- Err(gloo_storage::errors::StorageError::KeyNotFound(err)) =\u003e {\n- tracing::debug!(\"gloo error: {}\", err);\n- Ok(None)\n- }\n+ Err(gloo_storage::errors::StorageError::KeyNotFound(_)) =\u003e Ok(None),\n Err(e) =\u003e Err(SessionStoreError::Other(\n format!(\"SessionStorage error: {}\", e).into(),\n )),\n-- \n2.43.0\n\n\nFrom 69a1552424ffa439ea1022aa8e3f311ed77ab4df Mon Sep 17 00:00:00 2001\nFrom: \"@nekomimi.pet\" \u003cmeowskulls@nekomimi.pet\u003e\nDate: Fri, 19 Dec 2025 04:01:49 -0500\nSubject: [PATCH] add tracing feature to jacquard-axum\n\n---\n crates/jacquard-axum/Cargo.toml | 1 +\n crates/jacquard-axum/src/service_auth.rs | 20 +++++++++++++++++---\n 2 files changed, 18 insertions(+), 3 deletions(-)\n\ndiff --git a/crates/jacquard-axum/Cargo.toml b/crates/jacquard-axum/Cargo.toml\nindex 4e98e270..d724289f 100644\n--- a/crates/jacquard-axum/Cargo.toml\n+++ b/crates/jacquard-axum/Cargo.toml\n@@ -39,6 +39,7 @@ tracing = \"0.1.41\"\n [features]\n default = [\"service-auth\"]\n service-auth = [\"jacquard-common/service-auth\", \"dep:jacquard-identity\", \"dep:multibase\"]\n+tracing = []\n \n [dev-dependencies]\n axum-macros = \"0.5.0\"\ndiff --git a/crates/jacquard-axum/src/service_auth.rs b/crates/jacquard-axum/src/service_auth.rs\nindex 59d61a5f..43cd63e3 100644\n--- a/crates/jacquard-axum/src/service_auth.rs\n+++ b/crates/jacquard-axum/src/service_auth.rs\n@@ -572,10 +572,24 @@ fn extract_signing_key(methods: \u0026[VerificationMethod]) -\u003e Option\u003cPublicKey\u003e {\n \n match codec {\n // p256-pub (0x1200)\n- [0x80, 0x24] =\u003e PublicKey::from_p256_bytes(key_material).ok(),\n+ [0x80, 0x24] =\u003e PublicKey::from_p256_bytes(key_material)\n+ .inspect_err(|_e| {\n+ #[cfg(feature = \"tracing\")]\n+ tracing::error!(\"Failed to parse p256 public key: {}\", _e);\n+ })\n+ .ok(),\n // secp256k1-pub (0xe7)\n- [0xe7, 0x01] =\u003e PublicKey::from_k256_bytes(key_material).ok(),\n- _ =\u003e None,\n+ [0xe7, 0x01] =\u003e PublicKey::from_k256_bytes(key_material)\n+ .inspect_err(|_e| {\n+ #[cfg(feature = \"tracing\")]\n+ tracing::error!(\"Failed to parse secp256k1 public key: {}\", _e);\n+ })\n+ .ok(),\n+ _ =\u003e {\n+ #[cfg(feature = \"tracing\")]\n+ tracing::error!(\"Unsupported public key multicodec: {:?}\", codec);\n+ None\n+ }\n }\n }\n \n-- \n2.43.0\n\n\n",
"source": {
"branch": "main",
"repo": "at://did:plc:ttdrpj45ibqunmfhdsb4zdwq/sh.tangled.repo/3mad65sxrqv22",
"sha": "69a1552424ffa439ea1022aa8e3f311ed77ab4df"
},
"target": {
"branch": "main",
"repo": "at://did:plc:yfvwmnlztr4dwkb7hwz55r2g/sh.tangled.repo/3lzrya6fcwv22"
},
"title": "clean up more debug logs"
}